fix(opencode): resolve snapshots from git subdirectories#29705
Open
MuoDoo wants to merge 1 commit into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found potential related PRs that address similar snapshot/git subdirectory issues:
These PRs appear to address similar or overlapping concerns about resolving git operations from the correct directory context when working in subdirectories. You may want to review these to ensure there's no duplication of effort. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27688
Type of change
What does this PR do?
When opencode is launched from a git subdirectory, snapshot candidate paths can be worktree-relative while later pathspec operations run from the launch directory. This can make git resolve paths like
src/file.txtundersrc/src/file.txtand fail to record the snapshot.This PR resolves pathspec-consuming snapshot operations from the worktree root, makes untracked file paths worktree-relative, and adds a regression test for launching from a subdirectory.
Related prior attempts: #27737, #28131.
How did you verify your code works?
bun test test/snapshot/snapshot.test.ts --timeout 30000bun typecheckScreenshots / recordings
N/A, not a UI change.
Checklist