[Prototype] Change default link open behaviour to in-app browser by default#232
Draft
markmur wants to merge 2 commits into
Draft
[Prototype] Change default link open behaviour to in-app browser by default#232markmur wants to merge 2 commits into
markmur wants to merge 2 commits into
Conversation
markmur
changed the title
React Native — Coverage Report
|
markmur
changed the title
markmur
force-pushed
the
change-link-open-behaviour
branch
from
59568ed to
9931f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegated web links (
window.openand similar) previously bounced buyers out to the platform's external browser. That breaks flow for things like terms/policy pages opened mid-checkout. This PR flips the default so HTTPS links open in an in-app surface —SFSafariViewControlleron iOS, Custom Tabs on Android — whilemailto:,tel:, and custom schemes continue routing throughUIApplication.open/Intent.ACTION_VIEW. Merchants who want the old behavior can register aCheckoutProtocol.windowOpenhandler.Try the sample apps and tap a delegated link in checkout (e.g. a policy link). It should now stay in-app. The settings screen has been updated to let you toggle the alternative "External app" handler.