Skip to content

Fix React Native Swift lint CI parity#225

Open
kyle-schellen wants to merge 1 commit into
ks-dev-workspace-setupfrom
ks-rn-swift-lint-ci-parity
Open

Fix React Native Swift lint CI parity#225
kyle-schellen wants to merge 1 commit into
ks-dev-workspace-setupfrom
ks-rn-swift-lint-ci-parity

Conversation

@kyle-schellen
Copy link
Copy Markdown
Contributor

@kyle-schellen kyle-schellen commented May 27, 2026

What changed

  • Updates React Native lint CI so SwiftLint targets the RN Swift bridge with the RN SwiftLint config.
  • Adds a Mint-backed RN Swift lint/format CI check that runs the same ./scripts/lint_swift check entrypoint as local dev.
  • Excludes SwiftPM .build output from RN SwiftLint/SwiftFormat.
  • Applies the RN Swift lint/format fixes surfaced by the pinned toolchain.

Why

dev rn lint swift was catching RN Swift issues locally that CI was not catching. CI was running SwiftLint from the repo root with the root Swift config, and SwiftFormat was not running against the RN Swift bridge in CI.

How to test

  • dev rn lint swift
  • dev check

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kyle-schellen kyle-schellen mentioned this pull request May 27, 2026
11 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.59% (316/345) 87.25% (178/204) 100% (82/82)

@kyle-schellen kyle-schellen force-pushed the ks-rn-swift-lint-ci-parity branch from 9697cf4 to 3c882c5 Compare May 27, 2026 18:21
@kyle-schellen kyle-schellen marked this pull request as ready for review May 27, 2026 18:44
@kyle-schellen kyle-schellen requested a review from a team as a code owner May 27, 2026 18:44
@kyle-schellen kyle-schellen added the #gsd:50662 Rebase Checkout Kit on UCP label May 27, 2026 — with Graphite App
@kyle-schellen kyle-schellen force-pushed the ks-rn-swift-lint-ci-parity branch 2 times, most recently from 87beac2 to 9a39e3c Compare May 27, 2026 19:37
@kyle-schellen kyle-schellen force-pushed the ks-dev-workspace-setup branch from 2bf264d to 4275954 Compare May 27, 2026 19:37
@kyle-schellen kyle-schellen force-pushed the ks-dev-workspace-setup branch from 4275954 to 31ddca1 Compare May 28, 2026 13:17
@kyle-schellen kyle-schellen force-pushed the ks-rn-swift-lint-ci-parity branch from 9a39e3c to 0a4ad00 Compare May 28, 2026 13:17
@kyle-schellen kyle-schellen force-pushed the ks-dev-workspace-setup branch from 31ddca1 to e48931b Compare May 28, 2026 14:32
@kyle-schellen kyle-schellen force-pushed the ks-rn-swift-lint-ci-parity branch from 0a4ad00 to 68a7132 Compare May 28, 2026 14:32
@kyle-schellen kyle-schellen self-assigned this May 28, 2026
@kyle-schellen kyle-schellen force-pushed the ks-dev-workspace-setup branch from e48931b to 3ba3067 Compare May 28, 2026 16:54
@kyle-schellen kyle-schellen force-pushed the ks-rn-swift-lint-ci-parity branch from 68a7132 to 7639bfc Compare May 28, 2026 16:54
@kyle-schellen kyle-schellen force-pushed the ks-rn-swift-lint-ci-parity branch from 7639bfc to 858390a Compare May 28, 2026 17:00
Copy link
Copy Markdown
Contributor

@Juanita-Dash Juanita-Dash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants